-
Notifications
You must be signed in to change notification settings - Fork 213
Adds v2 test lab triggers #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
handler?: (event: CloudEvent<TestMatrixCompletedData>) => any | Promise<any> | ||
): CloudFunction<CloudEvent<TestMatrixCompletedData>> { | ||
if (typeof optsOrHandler === "function") { | ||
handler = optsOrHandler as (event: CloudEvent<TestMatrixCompletedData>) => any | Promise<any>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can change this to not be any | Promise ? (same with others)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a better recommendation?
We might be able to get away with void | Promise, but I'd argue it's better to be consistent with the other v2 event providers that all use any | Promise. For example remote config, storage, crashlytics, etc.
Also, we'd probably have to have a followup api review since this has already been approved by council
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess my main question was along the lines of if we could avoid the any
.
But if theres prior art, and would require api review again... I'm alright leave it as-is.
I love all the thoroough documentation!!! |
bd8947e
to
4a1e23d
Compare
This change adds test lab triggers to the v2 codebase and sneaks in some remote config changes. For remote config, we update the tsdoc strings for reference docs and remove @Alpha tags since the public docs have been published.
Test Lab functions: