Skip to content

Fix docs for v1 remote config #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Fix docs for v1 remote config #1205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/v1/providers/remoteConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
import { CloudFunction, EventContext, makeCloudFunction } from "../cloud-functions";
import { DeploymentOptions } from "../function-configuration";

/** @hidden */
/** @internal */
export const provider = "google.firebase.remoteconfig";
/** @hidden */
/** @internal */
export const service = "firebaseremoteconfig.googleapis.com";

/**
Expand All @@ -35,15 +35,15 @@ export const service = "firebaseremoteconfig.googleapis.com";
* @param handler A function that takes the updated Remote Config
* template version metadata as an argument.
*
* @return A Cloud Function that you can export and deploy.
* @returns A Cloud Function that you can export and deploy.
*/
export function onUpdate(
handler: (version: TemplateVersion, context: EventContext) => PromiseLike<any> | any
): CloudFunction<TemplateVersion> {
return _onUpdateWithOptions(handler, {});
}

/** @hidden */
/** @internal */
export function _onUpdateWithOptions(
handler: (version: TemplateVersion, context: EventContext) => PromiseLike<any> | any,
options: DeploymentOptions
Expand All @@ -59,7 +59,7 @@ export function _onUpdateWithOptions(

/** Builder used to create Cloud Functions for Remote Config. */
export class UpdateBuilder {
/** @hidden */
/** @internal */
constructor(private triggerResource: () => string, private options: DeploymentOptions) {}

/**
Expand Down