Migrate from prettier to eslint to match firebase/firebase-tools styling #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
force-pushed
the
dl-eslint
branch
4 times, most recently
from
5620dbd to
3d79214
Compare
Merged
taeold
added a commit
that referenced
this pull request
Aug 23, 2022
Turns out I missed most of the files for migration from prettier to eslint in #1194 due to poorly configured `.eslintignore` - it ignored all files under `src/v1` and `src/v2`! Correctly configure eslint and run `npm run format`. Again, I had to manually fixup issues like: 1. Remove empty function definition (prefer ()=>undefined over ()=>{}) 1. Remove unused arguments from function definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's bite the bullet - match styling of firebase/firebase-tools and start using eslint over prettier.
This change effectively touches almost all files in this repo, especially since eslint prefers double-quotes over single-quotes.
I've made couple of other changes to make eslint errors go away. Things like:
()=>undefinedover()=>{})In theory, these are just linter changes without changes to the runtime behavior. v4 launches will need good tests and bugbash anyway, so this feels like a great time to commit to this migration.