Skip to content

Allow RTDB instance to be specified when using makeDataSnapshot #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

rhodgkins
Copy link
Contributor

@rhodgkins rhodgkins commented Aug 28, 2020

Description

Allow creation of DataSnapshots for multiple RTDB instances.

Why

Currently the only way to create a DataSnapshot for different RTDB instances is to create a App per instance.

Code sample

const snapshot = makeDataSnapshot({ hello: 'world' }, 'path', null, 'https://another-instance.firebaseio.com');

Copy link
Contributor

@laurenzlong laurenzlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thank you for this! Just one nit on comment, rest looks good!

@rhodgkins rhodgkins force-pushed the datasnapshot-db-instances branch from 575d1af to 99cca66 Compare August 28, 2020 17:48
@rhodgkins rhodgkins force-pushed the datasnapshot-db-instances branch from 99cca66 to 3841cee Compare August 28, 2020 18:54
@rhodgkins rhodgkins requested a review from laurenzlong August 28, 2020 19:02
Copy link
Contributor

@laurenzlong laurenzlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll try to get this out soon, maybe at the same time as #71

@joehan joehan merged commit d319f93 into firebase:master Sep 3, 2020
@rhodgkins rhodgkins deleted the datasnapshot-db-instances branch September 3, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants