Skip to content

Improve cleanup type definition #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Improve cleanup type definition #185

merged 1 commit into from
Dec 6, 2022

Conversation

galkin
Copy link
Contributor

@galkin galkin commented Nov 26, 2022

Description

Right pull improves type definition for cleanup method.

Before:

import firebase_function_test from 'firebase-functions-test';
const ffTest = firebase_function_test();
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
ffTest.cleanup();

After

import firebase_function_test from 'firebase-functions-test';
const ffTest = firebase_function_test();
ffTest.cleanup();

@galkin
Copy link
Contributor Author

galkin commented Nov 29, 2022

@TheIronDev, @taeold, @blidd-google could you approve this tiny change?

@galkin
Copy link
Contributor Author

galkin commented Dec 1, 2022

@TheIronDev, @taeold, @blidd-google friendly reminder

@TheIronDev
Copy link
Contributor

@galkin Thank you for contributing!!

(and apologies for the delay.)

I just ran the CI test workflows, and there is a format issue blocking submission.

Would you be able to run npm run format:fix ?

Otherwise the code LGTM!

@galkin
Copy link
Contributor Author

galkin commented Dec 2, 2022

@TheIronDev done

@TheIronDev
Copy link
Contributor

Your update will get included in the next release (date is tbd.)

Thank you for contributing (and my apologies on the delays in the review!)

@TheIronDev TheIronDev merged commit 8775696 into firebase:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants