Fix Firebase Functions v4 compatibility issues. #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v4 SDK, we don't expose config singleton directly.
In v4 SDK, we don't expose config singleton directly.
1. Replace all use of __trigger annotation to __endpoint 2. Correct import path for Expression class/type.
TheIronDev
reviewed
Oct 14, 2022
TheIronDev
reviewed
Oct 14, 2022
blidd-google
approved these changes
Oct 14, 2022
|
Tests are broken because v4 sdk isn't available yet. This will be fixed in future PR where I pull in release candidate version as the dev dependency. |
taeold
added a commit
that referenced
this pull request
Oct 14, 2022
* Update mockConfig function for v4 firebase-functions (#173) V4 Functions SDK does not expose the config singleton directly. Use the internal-only `resetCache` function instead. * Fix Firebase Functions v4 compatibility issues. (#175) 1. Replace all use of __trigger annotation to __endpoint 2. Correct import path for Expression class/type * BREAKING: Drop support for Firebase Functions SDK v3 and below - take 2 (#178) We also pin down peer dep requirement for firebase-admin to peer dependencies required for v4 firebase-functions sdk. * Bump firebase functions sdk version to v4 release candidate. (#179)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all use of __trigger annotation to __endpoint
Correct import path for Expression class/type.