Skip to content

makeDocumentSnapshot check wrong option names. #79

Open
googleapis/nodejs-firestore
#1728
@rharter

Description

@rharter

makeDocumentSnapshot checks the options to see if there is an app property, but DocumentSnapshotOptions calls it firebaseApp. This leads to some weird casting requirements to use makeDocumentSnapshot with your own initialized app.

This issue is here.

if (has(options, 'app')) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions