-
Notifications
You must be signed in to change notification settings - Fork 28
feat: identity provider functions #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f6ed550
to
686604a
Compare
The time the event was triggered.""" | ||
|
||
|
||
class BeforeCreateResponse(_typing.TypedDict, total=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: What's the difference between typedict vs dataclass 🤔
should we prefer one style over another here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answer: typedict allows us to distinguish undefined vs null (in js)
options = _options.BlockingOptions(**kwargs) | ||
|
||
def before_user_signed_in_decorator(func: BeforeUserSignedInCallable): | ||
from firebase_functions.private._identity_fn import event_type_before_sign_in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: is lazy importing intentional? is there a rule of thumb you are using to choose lazy import vs top level import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answer: to avoid circular imports
Testing:
Deployed the following sample:
created a user with email
"hello123@dogs.com"
and function triggered:signed in a user with email
"hello123@cats.com"
and function triggered: