Add User Messaging Platform iOS support #1412

jonsimantov · 2023-08-03T20:44:28Z

Description

Provide details of the change, and generalize the change in the PR title above.

Add iOS implementation of GMA UMP SDK.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration tests in this PR, and also run locally.

Type of Change

Place an x the applicable box:

Bug fix. Add the issue # below if applicable.
New feature. A non-breaking change which adds functionality.
Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

github-actions · 2023-08-03T22:08:24Z

❌ Integration test FAILED

Requested by @jonsimantov on commit 890e829
Last updated: Fri Aug 18 14:07 PDT 2023
View integration test log & download artifacts

Failures	Configs
app_check	[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target] (1 failed tests) CRASH/TIMEOUT
auth	[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_ftl_target] (1 failed tests) CRASH/TIMEOUT
firestore	[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target] (1 failed tests) CRASH/TIMEOUT
gma	[TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: simulator_target] (5 failed tests) FirebaseGmaTest.TestAdViewErrorBadAdUnitId FirebaseGmaTest.TestInterstitialAdErrorBadAdUnitId FirebaseGmaTest.TestNativeAdErrorBadAdUnitId FirebaseGmaTest.TestRewardedAdErrorBadAdUnitId FirebaseGmaUmpTest.TestUmpLoadForm
messaging	[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target] (1 failed tests) CRASH/TIMEOUT
storage	[TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: simulator_target] (1 failed tests) FirebaseStorageTest.TestWriteAndReadCustomContentType

Add flaky tests to go/fpl-cpp-flake-tracker

…ebase-cpp-sdk into feature/ump-sdk-ios

Add a test skip macro for skipping on physical hardware.

…ebase-cpp-sdk into feature/ump-sdk-ios

a-maurice · 2023-08-16T20:57:48Z

gma/integration_test/Podfile

@@ -6,6 +6,7 @@ use_frameworks! :linkage => :static
 target 'integration_test' do
  pod 'Firebase/CoreOnly', '10.13.0'
  pod 'Google-Mobile-Ads-SDK', '10.9.0'
+  pod 'GoogleUserMessagingPlatform', '2.1.0'


Any changes need to be done to the update scripts so this gets updated automatically?

gma/integration_test/src/integration_test.cc

a-maurice · 2023-08-16T21:13:11Z

gma/integration_test/src/integration_test.cc

@@ -2818,12 +2889,12 @@ TEST_F(FirebaseGmaUmpTest, TestCanRequestAdsEEA) {
  using firebase::gma::ump::ConsentRequestParameters;
  using firebase::gma::ump::ConsentStatus;

-  TEST_REQUIRES_USER_INTERACTION;


Why do these no longer need user interaction?

Because I was able to add GetDebugDeviceId() to our test framework, so it can specify the debug settings even on FTL hardware.

The ones that show the consent form and/or the privacy form still do require user interaction, though.

gma/src/ios/ump/consent_info_internal_ios.mm

Return existing instance rather than creating new instance of internal class.

Add iOS files, copies of stubs for now.

652bb7e

jonsimantov changed the title ~~Add iOS files, copies of stubs for now.~~ Add User Messaging Protocol iOS support Aug 3, 2023

Format code.

246ab64

jonsimantov changed the title ~~Add User Messaging Protocol iOS support~~ Add User Messaging Platform iOS support Aug 3, 2023

Update cocoapod versions and add UMP pod.

8f54fad

github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Aug 3, 2023

github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 3, 2023

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 3, 2023

jonsimantov added 6 commits August 8, 2023 13:17

Merge branch 'feature_branch/ump-sdk' into feature/ump-sdk-ios

22a684f

Add iOS basics, also rename two enums.

77384f5

Fixes.

6be9f7c

Format code.

37b9d32

Merge branch 'feature/ump-sdk-ios' of https://github.com/firebase/fir…

3a46e8c

…ebase-cpp-sdk into feature/ump-sdk-ios

Fix compiler errors.

c6d98d3

github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 10, 2023

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 10, 2023

Add test flag for skipping on hardware.

063d678

jonsimantov marked this pull request as ready for review August 15, 2023 01:48

github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels Aug 15, 2023

jonsimantov added 5 commits August 14, 2023 19:04

Fix iOS implementation and tests to match actual results.

7ea9f64

Add a test skip macro for skipping on physical hardware.

Format code and add general GMA tests back in.

68a1698

Merge branch 'feature_branch/ump-sdk' into feature/ump-sdk-ios

08f5fa5

Enable App Transparency for iOS app.

de1f488

Merge branch 'feature/ump-sdk-ios' of https://github.com/firebase/fir…

57f9399

…ebase-cpp-sdk into feature/ump-sdk-ios

jonsimantov requested a review from a-maurice August 15, 2023 02:29

jonsimantov assigned a-maurice Aug 15, 2023

github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels Aug 16, 2023

jonsimantov added 6 commits August 16, 2023 10:39

Format code.

a705ec5

Format code.

d169883

Add a mutex to prevent race condition.

454bd7e

Update test to check race condition.

47408f6

Add include for lint

bdd4c57

Update test name.

da70121

github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 16, 2023

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 16, 2023

jonsimantov added 3 commits August 16, 2023 12:42

Remove user interaction flag from debug test.

b85feb3

Format code.

453d3f8

Remove UMP-only test mode.

d7ee1e1

a-maurice requested changes Aug 16, 2023

View reviewed changes

Remove unnecessary test stuff.

a99c762

Return existing instance rather than creating new instance of internal class.

github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 17, 2023

Fix assert.

e147305

github-actions bot added the tests: failed This PR's integration tests failed. label Aug 17, 2023

Fix stub to match iOS flow.

7a03dd9

github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Aug 17, 2023

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 17, 2023

a-maurice approved these changes Aug 17, 2023

View reviewed changes

jonsimantov merged commit 890e829 into feature_branch/ump-sdk Aug 18, 2023

github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 18, 2023

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 18, 2023

firebase locked and limited conversation to collaborators Sep 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add User Messaging Platform iOS support #1412

Add User Messaging Platform iOS support #1412

Uh oh!

jonsimantov commented Aug 3, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Aug 3, 2023 •

edited

Loading

Uh oh!

a-maurice Aug 16, 2023

Uh oh!

Uh oh!

Uh oh!

a-maurice Aug 16, 2023

Uh oh!

jonsimantov Aug 17, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add User Messaging Platform iOS support #1412

Add User Messaging Platform iOS support #1412

Uh oh!

Conversation

jonsimantov commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Type of Change

Notes

Uh oh!

github-actions bot commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Integration test FAILED

Uh oh!

a-maurice Aug 16, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

a-maurice Aug 16, 2023

Choose a reason for hiding this comment

Uh oh!

jonsimantov Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonsimantov commented Aug 3, 2023 •

edited

Loading

github-actions bot commented Aug 3, 2023 •

edited

Loading

jonsimantov Aug 17, 2023 •

edited

Loading