Skip to content

Increase retry for GS log fetch. #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Increase retry for GS log fetch. #1402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/gha/integration_testing/ftl_gha_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def _get_testapp_log_text_from_gcs(gcs_path):
logging.error("Unexpected error reading GCS log:\n%s", e)
return None

@retry(subprocess.CalledProcessError, tries=3, delay=10)
@retry(subprocess.CalledProcessError, tries=10, delay=5, backoff=1.5)
def _gcs_list_dir(gcs_path):
"""Recursively returns a list of contents for a directory on GCS."""
args = [GSUTIL, "ls", "-r", gcs_path]
Expand All @@ -83,7 +83,7 @@ def _gcs_list_dir(gcs_path):
return result.stdout.splitlines()


@retry(subprocess.CalledProcessError, tries=3, delay=10)
@retry(subprocess.CalledProcessError, tries=10, delay=5, backoff=1.5)
def _gcs_read_file(gcs_path):
"""Extracts the contents of a file on GCS."""
args = [GSUTIL, "cat", gcs_path]
Expand Down