Skip to content

Add a retry decorator to the GitHub log downloader. #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jul 13, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

This should fix the flaky GMA iOS "crash/timeout" test, as the error is often just that it's unable to fetch the test results (possibly because that test runs so quickly). Example log


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Ran GMA integration test on iOS a number of times without issues. Considering this usually flakes at least every other day, I'm willing to say this helps.

Also running integration tests in this PR, and packaging workflow, to ensure that the added Python module dependency doesn't break any of our build/test environments.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jul 13, 2023
@jonsimantov jonsimantov marked this pull request as ready for review July 13, 2023 22:20
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jul 13, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 13, 2023
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit af4e2b2
Last updated: Fri Jul 14 13:41 PDT 2023
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov requested a review from cynthiajoan July 13, 2023 22:22
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 14, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 14, 2023
@jonsimantov jonsimantov requested a review from a-maurice July 14, 2023 17:55
@jonsimantov
Copy link
Contributor Author

All tests and packaging passed, this is ready for review.

@jonsimantov jonsimantov merged commit af4e2b2 into main Jul 14, 2023
@jonsimantov jonsimantov deleted the add-retry-to-ftl-log-load branch July 14, 2023 18:07
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 14, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 14, 2023
tom-andersen pushed a commit that referenced this pull request Jul 17, 2023
* Add a retry decorator to the GitHub log downloader.

* Fix retry syntax.
@firebase firebase locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants