Skip to content

Add a GitHub warning to the iOS simulator logic #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Adds a GitHub warning to the iOS simulator logic, as a follow up to #1368


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Jun 28, 2023
@a-maurice a-maurice requested a review from sunmou99 June 28, 2023 20:21
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo works https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-warning-message
Not sure if print() works here. Should run some test or we have other examples in scripts.

Another nit, we could add check if available_versions:.

@jonsimantov jonsimantov self-requested a review June 28, 2023 20:56
@jonsimantov jonsimantov self-requested a review June 28, 2023 20:57
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See comment about log message.)

@a-maurice
Copy link
Contributor Author

echo works https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-warning-message Not sure if print() works here. Should run some test or we have other examples in scripts.

Another nit, we could add check if available_versions:.

The problem here is that this is the python script, so no access to echo. We use print in a couple of other scripts, so hopefully that does actually work.

@a-maurice a-maurice requested a review from jonsimantov June 28, 2023 21:06
@a-maurice
Copy link
Contributor Author

echo works https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-warning-message Not sure if print() works here. Should run some test or we have other examples in scripts.
Another nit, we could add check if available_versions:.

The problem here is that this is the python script, so no access to echo. We use print in a couple of other scripts, so hopefully that does actually work.

I did a quick test, and confirmed that using print generates a warning card on the action level, similar to echo.

@a-maurice a-maurice merged commit 1adbf0a into main Jun 28, 2023
@a-maurice a-maurice deleted the am-ios_installs branch June 28, 2023 22:08
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit 1adbf0a
Last updated: Wed Jun 28 18:18 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  FirestoreTest.TestQuerySnapshotEventsForDelete
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 29, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 29, 2023
@firebase firebase locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants