Skip to content

Add step to C++ packaging to create Windows package. #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2023
Merged

Add step to C++ packaging to create Windows package. #1370

merged 3 commits into from
Jun 30, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jun 28, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Packaging workflow runs here.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jun 28, 2023
@jonsimantov jonsimantov requested a review from cynthiajoan June 29, 2023 18:25
@jonsimantov jonsimantov merged commit 3c74d09 into main Jun 30, 2023
@jonsimantov jonsimantov deleted the add-windows-only-package branch June 30, 2023 18:01
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 30, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 3c74d09
Last updated: Fri Jun 30 13:42 PDT 2023
View integration test log & download artifacts

Failures Configs
gma [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2023
tom-andersen pushed a commit that referenced this pull request Jul 17, 2023
@jonsimantov @tom-andersen
Add step to C++ packaging to create Windows package. (#1370)
f127185 
* Add step to C++ packaging to create Windows package.

* Don't trigger integration tests until the Windows artifact is created too.
@firebase firebase locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @cynthiajoan