Skip to content

Clean up JNI task listeners per object #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 28, 2023
Merged

Clean up JNI task listeners per object #1358

merged 12 commits into from
Jun 28, 2023

Conversation

a-maurice
Copy link
Contributor

@a-maurice a-maurice commented Jun 22, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Add logic to the products that use objects to clean any pending Task listeners on destruction of that object. Refactor the string creation logic from Auth to a utility function so all the products can use the same.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Jun 22, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 22, 2023
@github-actions
Copy link

github-actions bot commented Jun 22, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @a-maurice on commit 8fecdb9
Last updated: Wed Jun 28 15:59 PDT 2023
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 22, 2023
@a-maurice a-maurice added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Jun 23, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 23, 2023
@a-maurice a-maurice changed the title Clean up Installations JNI task listeners Clean up JNI task listeners per object Jun 23, 2023
@a-maurice a-maurice added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. labels Jun 23, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 23, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 23, 2023
@a-maurice a-maurice requested a review from jonsimantov June 23, 2023 18:58
jonsimantov
jonsimantov previously requested changes Jun 26, 2023
View reviewed changes
@a-maurice a-maurice requested a review from jonsimantov June 26, 2023 22:48
@a-maurice a-maurice merged commit 8fecdb9 into main Jun 28, 2023
@a-maurice a-maurice deleted the am-jni_task_id branch June 28, 2023 20:15
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 28, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 28, 2023
@firebase firebase locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @jonsimantov