Skip to content

fix(fcm): Renamed FcmOptions types to FCMOptions #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2019
Merged

fix(fcm): Renamed FcmOptions types to FCMOptions #328

merged 1 commit into from
Aug 20, 2019

Conversation

hiranya911
Copy link
Contributor

Renamed the new types AndroidFcmOptions, APNSFcmOptions and FcmOptions to be PEP8 compliant.

RELEASE NOTE: The WebpushFcmOptions type is now deprecated. Developers should use the PEP8 compliant type name WebpushFCMOptions instead.

@hiranya911 hiranya911 self-assigned this Aug 20, 2019
@hiranya911 hiranya911 merged commit de4ee2d into master Aug 20, 2019
@hiranya911 hiranya911 deleted the hkj-fcm-options branch August 20, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees

@hiranya911 hiranya911

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @VinayGuthal