feat(rtdb): Support RTDB Emulator via FIREBASE_DATABASE_EMULATOR_HOST. #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
suggested changes
Jul 26, 2019
There was a problem hiding this comment.
Thanks @yuchenshi for implementing this. It looks pretty good. I added a few suggestions on how the code can be cleaned up a bit.
hiranya911
suggested changes
Aug 1, 2019
firebase_admin/db.py
Outdated
| return base_url, {'ns': namespace}, use_fake_creds | ||
|
|
||
| @classmethod | ||
| def _parse_production_url(cls, parsed_url): |
There was a problem hiding this comment.
Make this and _parse_db_url instance methods. Then you don't need to pass emulator_host around. It can be read from self.
There was a problem hiding this comment.
Thanks, but no, thanks. I just tried that and it made testing a nightmare. I don't want to initialize a full _DatabaseService class with all the options and monkey-patch os.environ just to test the parsing logic.
hiranya911
reviewed
Aug 1, 2019
yuchenshi
commented
Aug 1, 2019
hiranya911
suggested changes
Aug 1, 2019
There was a problem hiding this comment.
Thanks @yuchenshi. Looks pretty good. Just a couple of nits and questions. We can merge once they are resolved.
hiranya911
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
(Discussed internally.)
Testing
I've manually ran the integration tests with and without the emulator and verified that they pass.
We may consider running the emulator-based integration test on Travis in a follow up PR.
API Changes
No public API change except FakeCredential and the FIREBASE_DATABASE_EMULATOR_HOST env var.
RELEASE NOTE: Developers can now test their {{database}} API calls by directing the SDK traffic to the RTDB emulator. Set the
FIREBASE_DATABASE_EMULATOR_HOSTenvironment variable to specify the emulator endpoint inhost:portformat.