-
Notifications
You must be signed in to change notification settings - Fork 339
Migrating FCM Send APIs to the New Exceptions #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3218695
Migrated FCM send APIs to the new error handling regime
hiranya911 e734cf9
Moved error parsing logic to _utils
hiranya911 8df345a
Refactored OP error handling code
hiranya911 ce4a789
Fixing a broken test
hiranya911 3b6b78d
Added utils for handling googleapiclient errors
hiranya911 20d2e87
Added tests for new error handling logic
hiranya911 c0cf6f7
Updated public API docs
hiranya911 0ea0f82
Fixing test for python3
hiranya911 130a42f
Cleaning up the error code lookup code
hiranya911 de29a6b
Cleaning up the error parsing APIs
hiranya911 c536f5b
Cleaned up error parsing logic; Updated docs
hiranya911 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.