Skip to content

Add get operation for SAML provider configs. #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2020
Merged

Add get operation for SAML provider configs. #421

merged 1 commit into from
May 26, 2020

Conversation

micahstairs
Copy link
Contributor

Adds a get operation for SAML provider configs. I've included both unit tests and integration tests.

@micahstairs micahstairs force-pushed the micahstairs-saml-create-delete branch 2 times, most recently from 72170c4 to 28db833 Compare May 18, 2020 23:13
@micahstairs micahstairs force-pushed the micahstairs-get-saml branch from 3f10d18 to daa7b4e Compare May 21, 2020 21:59
Base automatically changed from micahstairs-saml-create-delete to idp-config May 21, 2020 23:26
@micahstairs micahstairs force-pushed the micahstairs-get-saml branch from daa7b4e to f643501 Compare May 22, 2020 00:53
hiranya911
hiranya911 approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 May 26, 2020
lahirumaramba
lahirumaramba approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahirumaramba lahirumaramba removed their assignment May 26, 2020
@micahstairs micahstairs merged commit 1e36411 into idp-config May 26, 2020
@micahstairs micahstairs deleted the micahstairs-get-saml branch May 26, 2020 18:30
micahstairs added a commit that referenced this pull request Jun 12, 2020
@micahstairs
Add get operation for SAML provider configs. (#421)
7732833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@micahstairs micahstairs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micahstairs @lahirumaramba @hiranya911