Rename OIDC delete operation and refactor integration tests. #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
suggested changes
May 13, 2020
src/test/java/com/google/firebase/auth/ProviderConfigTestUtils.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/firebase/auth/TenantAwareFirebaseAuthIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/firebase/auth/TenantAwareFirebaseAuthIT.java
Outdated
Show resolved
Hide resolved
hiranya911
approved these changes
May 13, 2020
micahstairs
added a commit
that referenced
this pull request
Jun 12, 2020
I've renamed the delete operation since we need separate methods for deleting OIDC and SAML provider configs. I've also created a ProviderConfigTestUtils class to house shared logic between TenantAwareFirebaseAuthIT and FirebaseAuthIT, and I've added a TemporaryProviderConfig class to make it easier for provider configs to be cleaned up automatically. I've structured this class in such a way that we can easily tack on logic to cleanup SAML provider configs as well. I've also decided to remove testGetUserWithMultipleTenantIds. I initially wrote this test to understand how tenant-aware auths and tenant-agnostic auths interacted with one another. In its existing state, it appears to be leaking created users, and in order to resolve this with TemporaryUser, we would need to declare multiple TemporaryUser objects as rules. I think it's better to avoid this complexity and remove this test. After all, this integration test is mainly making assertions about the server's behavior and not our behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've renamed the delete operation since we need separate methods for deleting OIDC and SAML provider configs.
I've also created a ProviderConfigTestUtils class to house shared logic between
TenantAwareFirebaseAuthITandFirebaseAuthIT, and I've added aTemporaryProviderConfigclass to make it easier for provider configs to be cleaned up automatically. I've structured this class in such a way that we can easily tack on logic to cleanup SAML provider configs as well.I've also decided to remove
testGetUserWithMultipleTenantIds. I initially wrote this test to understand how tenant-aware auths and tenant-agnostic auths interacted with one another. In its existing state, it appears to be leaking created users, and in order to resolve this withTemporaryUser, we would need to declare multipleTemporaryUserobjects as rules. I think it's better to avoid this complexity and remove this test. After all, this integration test is mainly making assertions about the server's behavior and not our behavior.NOTE: I also plan on creating a UserTestUtils class to reduce some code duplication between integration tests, but this will be in a separate PR.