Skip to content

Add operation to update OIDC provider configs. #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2020

Conversation

micahstairs
Copy link
Contributor

This adds an operation to update OIDC provider configs (can be done using either the tenant-aware or standard Firebase client).

This work is part of adding multi-tenancy support (see issue #332).

@micahstairs micahstairs changed the base branch from micahstairs-get-oidc to idp-config April 30, 2020 21:18
@micahstairs micahstairs force-pushed the micahstairs-update-oidc branch from 3533e8e to 2d6503d Compare April 30, 2020 21:28
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a few suggestions.

@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 Apr 30, 2020
@micahstairs micahstairs assigned hiranya911 and unassigned micahstairs May 1, 2020
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 May 1, 2020
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahirumaramba lahirumaramba removed their assignment May 1, 2020
@micahstairs micahstairs merged commit ee98321 into idp-config May 1, 2020
@micahstairs micahstairs deleted the micahstairs-update-oidc branch May 1, 2020 21:03
micahstairs added a commit that referenced this pull request Jun 12, 2020
This adds an operation to update OIDC provider configs (can be done using either the tenant-aware or standard Firebase client).

This work is part of adding multi-tenancy support (see issue #332).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants