Skip to content

fix: pascal case #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix: pascal case #1572

wants to merge 7 commits into from

Conversation

Mokto
Copy link

@Mokto Mokto commented May 30, 2023

First, thanks for your library, I'm REALLY happy to be able to remove the java dependency from our codebase!


Motivation: the most popular golang openapi plugin, https://github.com/swaggo/swag, generates references in that format:

packagename.myFunction.

This library then generates types with the name: packagename_myFunction.

My PR is addressing that issue and would generate PackagenameMyFunction


  1. Any typescript interface should be written in pascal case, in my opinion.
  2. The java library was already changing those types into pascal case.

Note: this change is really major and should be considered as a breaking change. I can potentially add a new parameter to the command line tool to be compatible with the previous versions.

@ferdikoomen
Copy link
Owner

ferdikoomen commented Jul 5, 2023

@Mokto We should definitely have a flag for this, since its a breaking change. Would you be able to add this? Ideally we could have a flag called --case, with options for pascal, snake, etc.?

Also check this PR: #1465

@ferdikoomen
Copy link
Owner

@Mokto Closing this PR since there has been no acitivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants