Skip to content

Update Node versions in CI #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

denis-sokolov
Copy link
Contributor

6 and 8 have reached their end of life, 14 and 15 are now in.

https://github.com/nodejs/Release

Checklist

@zekth
Copy link
Member

zekth commented Jan 18, 2021

Node 11 and 13 can be dropped too

@denis-sokolov
Copy link
Contributor Author

Indeed, thanks.

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this module is used by fastify v2
https://github.com/fastify/fastify/blob/e3850c9f0936730fb2b8eaa084c78d8c3ca2ee57/package.json#L156 that support older nodejs versions, I would keep the node 6 and 8, and drop them in the next major version of this module

@denis-sokolov denis-sokolov mentioned this pull request Jan 18, 2021
4 tasks
@denis-sokolov
Copy link
Contributor Author

Returned 6 and 8.

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina
Copy link
Member

Please add back the ones you removed.

@denis-sokolov
Copy link
Contributor Author

@mcollina, I’ve returned 6 and 8 a while ago. Do you mean 11 and 13, too?

@mcollina
Copy link
Member

Essentially dropping anything from that list is a semver-major change that we are trying to avoid. Please add back 11 and 13.

@denis-sokolov
Copy link
Contributor Author

I understand your reasons, I was looking for an explicit judgement call on your goals. Done now.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4cb9129 into fastify:master Jan 18, 2021
@denis-sokolov denis-sokolov deleted the node-versions-in-ci branch January 18, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants