-
-
Notifications
You must be signed in to change notification settings - Fork 17
Update Node versions in CI #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Node 11 and 13 can be dropped too |
Indeed, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this module is used by fastify v2
https://github.com/fastify/fastify/blob/e3850c9f0936730fb2b8eaa084c78d8c3ca2ee57/package.json#L156 that support older nodejs versions, I would keep the node 6 and 8, and drop them in the next major version of this module
Returned 6 and 8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please add back the ones you removed. |
@mcollina, I’ve returned 6 and 8 a while ago. Do you mean 11 and 13, too? |
Essentially dropping anything from that list is a semver-major change that we are trying to avoid. Please add back 11 and 13. |
b393296
to
ecd8dcb
Compare
I understand your reasons, I was looking for an explicit judgement call on your goals. Done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6 and 8 have reached their end of life, 14 and 15 are now in.
https://github.com/nodejs/Release
Checklist
npm run test
andnpm run benchmark
and the Code of conduct