-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Replace plaintext auth tokens with HttpOnly cookies #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sinkozs
wants to merge
13
commits into
fastapi:master
Choose a base branch
from
sinkozs:use-http-only-cookie
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken in plain text
…-only cookie on logout
b0cb31b
to
71affa9
Compare
what happens to the swagger docs using this implementation. when we want authenticate it seems like pasting any text it authorizes automatically no request is sent to the server. |
After some reserach i found this https://swagger.io/docs/specification/v3_0/authentication/cookie-authentication/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently authentication tokens are sent in plain text format. This can be a security vulnerability because attackers can run malicious JS scripts in the browser to access the user's token and perform session hijacking. A recommended solution for this vulnerability is to send auth tokens in a Cookie with the HttpOnly flag set. HttpOnly cookies’ content is not accessible from JavaScript, preventing XSS attacks from stealing these tokens.
Backend changes:
create_access_token
function to generate the JWT token but instead of returning it directly in the/login
endpoint, we return a JSONResponse with an http-only cookie, which contains the token.get_current_user
function, now there is anAPIKeyCookie
dependency, but the way we decode the JWT token didn't change./logout
endpoint which deletes the cookie.Frontend changes:
withCredentials=true
parameter to include the cookies in the requestsaccess_token
inlocalStorage
(the token is not accessible from JS anymore), now we store theis_authenticated
boolean value and use it to check authentication and remove it during logoutBefore:
After: