Skip to content

Replace get_event_loop with single methods in conftest #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

vittoriozamboni
Copy link
Contributor

Removes the warning in Python 3.10 caused by get_event_loop when a current loop is not present. See also this discussion

tests_warning

After the patch, no warning is raised and all tests pass.

tests_no_warnings

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #4 (bd17247) into main (9ca6d87) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files           2        2           
  Lines         101      101           
=======================================
  Hits           65       65           
  Misses         36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca6d87...bd17247. Read the comment docs.

@frankie567
Copy link
Member

Yes, that's something I gradually update in my projects :) Thank you for catching it!

@frankie567 frankie567 merged commit 4dd88c3 into fastapi-users:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants