Skip to content

Changed Collection inner class to Settings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

vittoriozamboni
Copy link
Contributor

Renaming the inner class Collection to Settings as updated in beanie 1.11.

test_no_warnings

@vittoriozamboni
Copy link
Contributor Author

Closes #2

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #3 (078c561) into main (9ca6d87) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files           2        2           
  Lines         101      101           
=======================================
  Hits           65       65           
  Misses         36       36           
Impacted Files Coverage Δ
fastapi_users_db_beanie/__init__.py 64.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca6d87...078c561. Read the comment docs.

@frankie567
Copy link
Member

Hi @vittoriozamboni! Thank you for catching this, much appreciated 🙏

@frankie567 frankie567 merged commit 0f3609c into fastapi-users:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants