Skip to content

Browsertesting #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 27, 2016
Merged

Browsertesting #57

merged 13 commits into from
Sep 27, 2016

Conversation

srijken
Copy link
Contributor

@srijken srijken commented Sep 26, 2016

Goal is to be able to run the tests both as a node process, as well as a browser plugin.

  • *-spec.ts
    runs in both testsuites
  • *-browserspec.ts
    runs in browser suite
  • *-nodespec.ts
    runs in node suite

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sander Rijken seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

"typings/mocha/mocha.d.ts",
"typings/chai/chai.d.ts",
"typings/node/node.d.ts",
"typings/stack-trace/stack-trace.d.ts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave node.d.ts and stack-trace.d.ts out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done..

@srijken srijken merged commit 8dfa574 into master Sep 27, 2016
@srijken srijken deleted the browsertesting branch September 27, 2016 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants