Allow for multiple install calls #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build failure is due to an iojs string matching issue vs. these changes in particular. |
|
Any chance on feedback here? I also have a patch that adds support map support for runtime transpiled files that have inline source maps attached but it depends on many of the things here. |
|
@kpdecker Sorry for the silence, would you mind rebasing on master? |
kpdecker
force-pushed
the
chained-retrieve
branch
from
2d1e2e3 to
52f4a69
Compare
|
Rebased |
This allows for multiple libraries to utilize this without stepping on each other’s toes. This makes the retrieve helpers additive, giving priority to the last retrieve method registered. In the event of a miss, the next method is called up to and including the default behavior. The `overrideRetriveFile` and `overrideRetrieveSourceMap` flags are added if this behavior is not desired but this is something that most libraries should avoid to be good citizens. Flagged behaviors will now be on if any of the install calls dictate that they would be. Fix for evanw#91
kpdecker
force-pushed
the
chained-retrieve
branch
from
52f4a69 to
b40cc25
Compare
|
I think this looks good 👍 I'll give the other maintainers a few days to look at this, if there are no problems we'll merge it. @julien-f Feel free to merge if you think it looks good 👍 |
|
Any thoughts on this? |
|
Merging 👍 |
LinusU
added a commit
that referenced
this pull request
Nov 30, 2015
Allow for multiple install calls
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for multiple libraries to utilize this without stepping on each other’s toes.
This makes the retrieve helpers additive, giving priority to the last retrieve method registered. In the event of a miss, the next method is called up to and including the default behavior. The
overrideRetriveFileandoverrideRetrieveSourceMapflags are added if this behavior is not desired but this is something that most libraries should avoid to be good citizens.Flagged behaviors will now be on if any of the install calls dictate that they would be.
Fix for #91