support charset in data url #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
|
Test passes in browser! Good to merge 👍 |
| } catch (e) { | ||
| compareLines(e.stack.split('\n'), expected); | ||
| } | ||
| fs.unlinkSync('.generated.js'); |
There was a problem hiding this comment.
Why do you create/delete .generated.js yourself instead of using compareStackTrace()?
There was a problem hiding this comment.
compareStackTrance() is hard coded to use data:application/json;base64, (aka. no charset). I didn't want to change it because we should test for both. I didn't want to add an extra parameter because I felt that it added too much clutter vs. the benefit, thus I just inlined the relevant parts in this test.
There was a problem hiding this comment.
Fair enough.
Would you mind adding a small comment above the test explaining that this is some duplicated code and why it is reasonable to do so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix first suggested by @nopnop in #65 but slightly modified for code readability and with added test.