Skip to content

buttonBackground prop to customize the inner btn #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2018

Conversation

cristiandan
Copy link
Contributor

No description provided.

@cristiandan
Copy link
Contributor Author

can you check this PR @euvl ?

@euvl
Copy link
Owner

euvl commented Apr 24, 2018

Hey sure, sorry, i am having a lot of work last couple of weeks.

I will review it when i have at least a little of free time and not feeling sick from javascript 😆

@cristiandan
Copy link
Contributor Author

Oh man, sorry to hear that. No worries 😄

@euvl
Copy link
Owner

euvl commented Apr 26, 2018

Hey, looks good to me 👍

The only request would be to rename a prop to buttonColor or switchColor, etc, because we already have one color prop for component's background and buttonBackground sounds a bit confusing to me (if you think about the whole component rather than particular html element within it)

Nice work 👍

@euvl euvl merged commit 08da79e into euvl:master Apr 26, 2018
@euvl
Copy link
Owner

euvl commented Apr 26, 2018

Merged, will publish new version tonight

@cristiandan
Copy link
Contributor Author

thank you @euvl

@cristiandan
Copy link
Contributor Author

let me know pls when you have time for the new version on npm 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants