Skip to content

first pass of keyboard support #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nelsonpecora
Copy link

@nelsonpecora nelsonpecora commented Sep 11, 2017

  • adds tabindex="0" to the labels, allowing tab and shift+tab navigation
  • adds toggle when pressing space, to simulate native keyboard toggling
  • note: I didn't add any focus styles, so right now this uses native ones. not sure if you want to add some.
  • fixes Keyboard support? #21

19245c02-f9ef-4127-8565-37d0c7712367-608-00018ebfc9f7bb71

@euvl
Copy link
Owner

euvl commented Sep 12, 2017

Hey! thanks for a PR! I will review it a bit later 👍
Quick question, it seems that there is no check whether component is focused or not (for space button click), does it need one?

@nelsonpecora
Copy link
Author

No worries! I don't think it needs a check, since the keyboard event will only fire on that if it's focused (or if a child is focused, but it has no dynamic children), but I'm not 100% sure on that front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard support?
2 participants