fixed bug in windows build with default charset #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmk135
approved these changes
Dec 19, 2022
|
@kirill-shershen thanks a lot for the contribution! |
arianamiri
pushed a commit
to arianamiri/python-dependency-injector
that referenced
this pull request
Feb 18, 2024
Co-authored-by: kirill-shershen <kirill.shershen@alao.ch>
arianamiri
pushed a commit
to arianamiri/python-dependency-injector
that referenced
this pull request
Feb 18, 2024
Co-authored-by: kirill-shershen <kirill.shershen@alao.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got some problems when i tried to build the package on windows 11 with cp1251 encoding by default.
UnicodeDecodeError: 'charmap' codec can't decode byte 0x98 in position 8667: character maps to <undefined>