Error at generating PlatformIO manifest

[HamzaHajeir]

Hi There

The ./build.sh script ends with:

fatal: ref HEAD is not a symbolic ref
usage: gen_platformio_manifest.py [-h] -o DST_DIR -s VERSION_STRING -c COMMIT_HASH
gen_platformio_manifest.py: error: argument -s/--version-string: expected one argument

It seems to me, however, related to the patches done to esp_eth component.

$ git symbolic-ref --short HEAD
fatal: ref HEAD is not a symbolic ref

and:

$ git status
HEAD detached at cb174b0fe1
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified: components/esp_eth/include/esp_eth_mac.h
modified: components/esp_eth/src/esp_eth_mac_dm9051.c
modified: components/esp_eth/src/esp_eth_mac_ksz8851snl.c
modified: components/esp_eth/src/esp_eth_mac_w5500.c

no changes added to commit (use "git add" and/or "git commit -a")

I've temporarily override it by a manual generation.

[krdarrah]

Same issue here - this works:
./build.sh -t esp32c3 -b build

this does not:
./build.sh -t esp32c3

Get this:
usage: gen_platformio_manifest.py [-h] -o DST_DIR -s VERSION_STRING -c COMMIT_HASH gen_platformio_manifest.py: error: argument -s/--version-string: expected one argument

[HamzaHajeir]

Hi @krdarrah

It's the issue of this command:

esp32-arduino-lib-builder/build.sh

Line 234 in c39e942

python3 ./tools/gen_platformio_manifest.py -o "$TOOLS_JSON_OUT/" -s $(git -C "$IDF_PATH" symbolic-ref --short HEAD || git -C "$IDF_PATH" tag --points-at HEAD) -c $(git -C "$IDF_PATH" rev-parse --short HEAD)

Wherein git in esp-idf repository failed to symbolic-ref, so I've manually called the script providing mockup argument.

python3 ./tools/gen_platformio_manifest.py -o ./out/tools/esp32-arduino-libs -s release/v5.1 -c $(git -C esp-idf rev-parse --short HEAD)

[me-no-dev]

how did you guys setup ESP-IDF for this command to fail?

[HamzaHajeir]

It was the responsibility of ./build.sh script, with provided esp-idf branch `release/v5.1`

…

On Fri, Oct 13, 2023, 10:19 Me No Dev ***@***.***> wrote: how did you guys setup ESP-IDF for this command to fail? — Reply to this email directly, view it on GitHub <#139 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3O7J43HABVPFXADU6MND3X7DTQPANCNFSM6AAAAAA5XXYEPU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[me-no-dev]

that is rather strange, given that CI runs that same script and it works fine. if you run git -C $IDF_PATH symbolic-ref manually, what does it return?

[HamzaHajeir]

It does return this line:

fatal: ref HEAD is not a symbolic ref

..

…

On Fri, Oct 13, 2023, 11:17 Me No Dev ***@***.***> wrote: that is rather strange, given that CI runs that same script and it works fine. if you run git -C $IDF_PATH symbolic-ref manually, what does it return? — Reply to this email directly, view it on GitHub <#139 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3O7J4MLHTTBVY6RXDPSSLX7D2KXAVCNFSM6AAAAAA5XXYEPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRRGEYDEOBWGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Jason2866]

Can confirm this issue. It works locally the first run. All runs after do fail here.
The issue never happens with Github Actions, since it is always "the first run"

[me-no-dev]

interesting... what would be different? I am using the same scripts here. @Jason2866 what does git status say?

[brentru]

@me-no-dev Having a similar issue as discussed above, except running ./build.sh fails at:

-- Generating done (1.2s)
-- Build files have been written to: /Users/brentrubell/Desktop/github_brentru/esp32-arduino-lib-builder/build
make: *** No rule to make target `idf_libs'.  Stop.
command "idf_libs" is not known to idf.py and is not a Unix Makefiles target

Edit: this is from not having ninja installed and doesn't error since installing.

I also think it may be due to the patches within esp_eth as they require a manual confirmation prompt the second time you run the script.

I've included the script output on this gist and highlighted the line with the symbolic ref issue: https://gist.github.com/brentru/aa9acf05b808575b753f6e461509bf35#file-gistfile1-txt-L281

Everything is configured on a local machine running macOS and bash shell.

[me-no-dev]

@brentru you must be running the script from the wrong folder. Rules for idf_libs are defined in the Arduino component

[Jason2866]

@me-no-dev

/Volumes/T7-Mac/esp32-arduino-lib-builder/out/tools/esp32-arduino-libs/tools.json generated
Schwerwiegend: ref HEAD is not a symbolic ref
usage: gen_platformio_manifest.py [-h] -o DST_DIR -s VERSION_STRING -c COMMIT_HASH
gen_platformio_manifest.py: error: argument -s/--version-string: expected one argument

hans@MacBook-Air-von-Johann esp32-arduino-lib-builder % git status
Auf Branch v5.1_no_SECP256R1
Ihr Branch ist auf demselben Stand wie 'origin/v5.1_no_SECP256R1'.

Unversionierte Dateien:
  (benutzen Sie "git add <Datei>...", um die Änderungen zum Commit vorzumerken)
	release-info.txt

nichts zum Commit vorgemerkt, aber es gibt unversionierte Dateien
(benutzen Sie "git add" zum Versionieren)

[me-no-dev]

I can not get myself in this situation... everything works. I do have an idea though... it will build but the PIO manifest might need editing.
Around line 232 of build.sh edit to look like this:

# Generate PlatformIO manifest file
if [ "$BUILD_TYPE" = "all" ]; then
    ibr=$(git -C "$IDF_PATH" symbolic-ref --short HEAD || git -C "$IDF_PATH" tag --points-at HEAD)
    ic=$(git -C "$IDF_PATH" rev-parse --short HEAD)
    python3 ./tools/gen_platformio_manifest.py -o "$TOOLS_JSON_OUT/" -s "$ibr" -c "$ic"
    if [ $? -ne 0 ]; then exit 1; fi
fi

[Jason2866]

@me-no-dev Not yet

/Volumes/T7-Mac/esp32-arduino-lib-builder/out/tools/esp32-arduino-libs/tools.json generated
Schwerwiegend: ref HEAD is not a symbolic ref
Failed to find a regex match for 'v(?P<MAJOR>0|[1-9]\d*)\.(?P<MINOR>0|[1-9]\d*)\.*(?P<PATCH>0|[1-9]\d*)*' in ''
Failed to convert version ''

[me-no-dev]

well... for some reason IDF is not on a properly named branch. So PIO can not extract the correct version. Maybe just comment the call... I can test if it's empty string and skip it... but why is it even happening? What did you guys do to your IDFs?

[Jason2866]

What did you guys do to your IDFs?

Happens with orig. espressif repo and branch for me too. Anyways not a big deal for me. In CI it is working (since first run). Building local i just do what you suggested -> commenting out that part.
For building local it is more anyoing that the Ethernet patch part needs human interaction what to do.