3.0.0-alpha3 escaping fix #8968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What is the IDE version you are using ? We were having this issue on the CI but it was due to an old IDE version being used. It was fixed in #8961. |
IDE1 ( ARDUINO IDE VERSION: 1.8.13 ) GitHub Actions build log : https://github.com/lyusupov/SoftRF/actions/runs/7123496016/job/19396200382 |
|
@pillo79 could you please comment on this. It is indeed the case that older IDE1 versions have issue with escaping that line. |
VojtechBartoska
added
the
Resolution: Awaiting response
|
Thanks for the heads-up @me-no-dev! We don't support the old IDE anymore so I had not checked that... but it's such an easy fix to make everyone happy, I'm all for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On a Linux host the alpha3 gives a build error like this:
alpha2 was fine.
The issue looks very similar to #8424
The idea of this fix was taken from that PR #8433 .