-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Alternative Improve _uploadReadByte #2656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
me-no-dev
merged 12 commits into
espressif:master
from
vicatcu:alternative_improve_uploadReadByte
Apr 12, 2019
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2dfed2f
add opportunity for more than one retry to _uploadReadByte
vicatcu 87aa404
an alternative timeout-based method to making _uploadReadByte more re…
vicatcu 1670366
move timing variables in the correct scope
vicatcu f8b9ab3
implement and use client.getTimeout instead of hard-coded timeout in …
vicatcu 6000909
add missing return
vicatcu 50594ca
some refactoring to address respecting the timeout in a potentially d…
vicatcu eadb93a
fix spelling in comment
vicatcu d5c501f
address review comments; move impl to cpp file for getTimeout, and re…
vicatcu 2076745
remove redundant cast
vicatcu e43f161
need to check for timeout outside the inner while as well
vicatcu 390f19b
update WebUpdate example to print something in unexpected callback co…
vicatcu 3e7dd27
update log_e messages per review comments
vicatcu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.