-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add WiFiSSLClient #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WiFiSSLClient #152
Conversation
let's start with moving the files out of the core. Maybe the whole SSL Client and eventually server should be a separate library (again nothing in the core). |
Sounds good. The files in the core can easily be moved to the same folder of library. Also, you can format or edit anything you want =) |
@@ -0,0 +1,33 @@ | |||
/* Provide SSL/TLS functions to ESP32 with Arduino IDE | |||
* Ported from Ameba8195 (no license specified) to ESP32 by Evandro Copercini - 2017 - Public domain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid we need to get some confirmation about the original license of these files before we can consider adding them to the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right.
These files just process the input to make a good call to ard_ssl.c
I will rewrite them based on WifiClientSecure of ESP8266 and make this lib compatible with ESP8266 arduino sketches.
Also I will move out of the core folder as @me-no-dev request.
Provide SSL/TLS functions to ESP32 with Arduino IDE