Skip to content

fix(board): Update Pin compatibility #11473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Conversation

SooDragon
Copy link
Contributor

fix: Update Pin compatibility

Description of Change

Generally, ESP32-Arduino Users define there Arduino style pin definition like D1, D2, D3
Geekble nano didn't supported that definition for digital pins
Fixed the compatibility issues

Tests scenarios

Geekble nano Ver.2.0 board with Arduino IDE 2.3.5, Arduino esp32 core v3.2.0

Related links

fix: Update Pin compatability
@SooDragon SooDragon requested a review from P-R-O-C-H-Y as a code owner June 16, 2025 02:48
Copy link
Contributor

github-actions bot commented Jun 16, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SooDragon, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8100531

@SooDragon SooDragon closed this Jun 16, 2025
@SooDragon SooDragon reopened this Jun 16, 2025
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added Type: 3rd party Boards Status: Pending Merge Pull Request is ready to be merged labels Jun 16, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y changed the title fix: Update Pin compatibility fix(board): Update Pin compatibility Jun 16, 2025
@me-no-dev me-no-dev merged commit 2283937 into espressif:master Jun 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants