Skip to content

feat(codeowners): Initial CODEOWNERS setup #11397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+70 −0
Open

feat(codeowners): Initial CODEOWNERS setup #11397

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eefc8fe
feat(codeowners): Initial CODEOWNERS setup
lucasssvaz May 23, 2025
539463a
fix(comment): Improve comment
lucasssvaz May 23, 2025
d9444a7
fix(codeowners): Add teams
lucasssvaz May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# CODEOWNERS for ESP32 Arduino Core

# This file is used to specify the code owners for the ESP32 Arduino Core.
# Read more about CODEOWNERS:
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
# Note that order matters. The last matching pattern will be used.

# The default owners are the active developers of the ESP32 Arduino Core.
# Refrain from using @espressif/arduino-esp32 to avoid spamming non-developers with review requests.
* @espressif/arduino-devs

# CI
/.github/ @lucasssvaz @me-no-dev @P-R-O-C-H-Y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and optionally espressif/ci here, just in case some workflow has to be updated due to a security issue

Copy link
Collaborator Author

@lucasssvaz lucasssvaz May 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We change our CI files quite frequently. Wouldn't this spam the CI team with review notifications? I have never used CODEOWNERS before so I don't know. The idea is to enable the branch protection rule to require codeowners review and AFAIK this automatically requests the review of all owners.

/tests/ @lucasssvaz @P-R-O-C-H-Y

# Tools
/tools/ @me-no-dev
/tools/pre-commit/ @lucasssvaz
/tools/add_lib.sh @P-R-O-C-H-Y

# Pre-commit
/.* @lucasssvaz # Files in root directory that start with a dot.

# Git Files
/.gitignore @espressif/arduino-devs
/.gitmodules @espressif/arduino-devs

# Documentation
/docs/ @pedrominatel
/.github/ISSUE_TEMPLATE/ @pedrominatel
/.github/PULL_REQUEST_TEMPLATE.md @pedrominatel
/.readthedocs.yaml @pedrominatel
/*.md @pedrominatel

# Boards
/variants/ @P-R-O-C-H-Y
/boards.txt @P-R-O-C-H-Y

# Arduino as Component
/idf_component_examples/ @SuGlider
/idf_component.yml @SuGlider @me-no-dev
/CMakeLists.txt @SuGlider @me-no-dev
/Kconfig.projbuild @SuGlider @me-no-dev

# Build System
/package.json @me-no-dev
/platform.txt @me-no-dev
/programmers.txt @me-no-dev
/package/ @me-no-dev

# Libraries
/libraries/ESP_NOW/ @P-R-O-C-H-Y @lucasssvaz
/libraries/Ethernet/ @me-no-dev
/libraries/Matter/ @SuGlider
/libraries/Network/ @me-no-dev
/libraries/OpenThread/ @SuGlider
/libraries/PPP/ @me-no-dev
/libraries/USB/ @SuGlider
/libraries/WiFi/ @me-no-dev
/libraries/WiFiProv/ @me-no-dev
/libraries/Wire/ @me-no-dev
/libraries/Zigbee/ @P-R-O-C-H-Y

# CI JSON
# Keep this after other libraries and tests to avoid being overridden.
**/ci.json @lucasssvaz

# The CODEOWNERS file should be owned by the developers of the ESP32 Arduino Core.
# Leave this entry as the last one to avoid being overridden.
/.github/CODEOWNERS @espressif/arduino-devs @espressif/admins