ESP32 ETH.h linkUp never reports true

[MartinMueller2003]

Board

ESP32 All

Device Description

LoLin D32 Pro. ESP32-CAM, TTGO - all

Hardware Configuration

LAN 8720 Ethernet Adapter

Version

v2.0.1

IDE Name

Arduino 1.8.1

Operating System

ESP32

Flash frequency

1

PSRAM enabled

yes

Upload speed

900k+

Description

ETH.h has no code that ever sets the link up flag to true. This results the linkUp function to always report false even when the link is up and passing data. The link up flag is used when compiled for any ESP32 platform.

Sketch

Example sketch from the repository modified to call ETH.linkUp and print result.

Debug Message

No debug message needed. Code review identified this issue

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[TD-er]

Yep, this is a bug indeed, introduced recently as it used to work just fine.

arduino-esp32/libraries/Ethernet/src/ETH.cpp

Lines 517 to 524 in caef400

	bool ETHClass::linkUp()
	{
	#ifdef ESP_IDF_VERSION_MAJOR
	return eth_link == ETH_LINK_UP;
	#else
	return eth_config.phy_check_link();
	#endif
	}

The enum eth_link is never set other than what the constructor does.

There are other functions which currently lack implementation too, like fullDuplex()

[VojtechBartoska]

Hello, can you please retest this on v2.0.3-rc1?

[TD-er]

Hello, can you please retest this on v2.0.3-rc1?

This also still has the same code as when it was reported:

2.0.3-RC1:

arduino-esp32/libraries/Ethernet/src/ETH.cpp

Lines 541 to 548 in 1e388a2

	bool ETHClass::linkUp()
	{
	#ifdef ESP_IDF_VERSION_MAJOR
	return eth_link == ETH_LINK_UP;
	#else
	return eth_config.phy_check_link();
	#endif
	}

[VojtechBartoska]

Adding to the roadmap.