Fixing final write length for sendContent_P #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
igrr
added a commit
that referenced
this pull request
Oct 17, 2015
Fixing final write length for sendContent_P
igrr
added a commit
that referenced
this pull request
Oct 29, 2015
Fixing final write length for sendContent_P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memccpy_P function returns the first byte after the last character written into the destination. The current implantation of sendContent_P uses pointer arithmetic incorrectly:
The problem is that
contentNextis relative to the destination,contentUnit, butcontentis in ROM. As a result, the number of remaining bytes is complete wrong.Oh, and this is covered by issue 864 that I filed.