-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Use placement new for ETSTimer - no heap fragmentation #6164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
617fdf0
Use placement new for ETSTimer - no heap fragmentation, new/delete se…
dok-net e7af1c3
Make change completely invisible to derived classes at compile-time.
dok-net c08c70e
Merge branch 'master' into TickerSingleMemChunk
dok-net 8dfb2fc
Fix "sizeof() incomplete type ETSTimer" error.
dok-net c2bb84e
C++ reinterpret_cast<> instead of C-style cast.
dok-net c6c4183
Simplify casts.
dok-net 64b4d0f
Revert to complete placement new treatment of ETSTimer member.
dok-net 6dad1ac
Cleanup includes
dok-net 55c1c24
Fix omitted casts
dok-net 3d8ad6d
Change per review https://github.com/esp8266/Arduino/pull/6164#pullre…
dok-net d941a9f
wtf - local compile didn't catch this sloppy mistake
dok-net 1280543
Resolves review https://github.com/esp8266/Arduino/pull/6164#discussi…
dok-net e82de34
Reviewer stated that floating point operations are inlined, software …
dok-net File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.