Move all SSL constants into PROGMEM, free 1.2KB #6162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite all the integer math operations with const input parameters to use PROGMEM properly (pgm_read_xx or memcpy_P), and move all the EC order and generators and SHA OIDs to PROGMEM. This frees around 1.2KB of heap for any SSL applications. Also delete unneeded objects from the bearssl.a library to shrink the GIT repo size.
|
No problems so far using HTTPS updater. |
|
@TD-er, did you give this PR a test with your app? Anything to report? |
|
@earlephilhower Nope, haven't tested it, since we currently have no SSL code in use. So I cannot say it will break previous implementations, since we simply have none (yet). |
devyte
approved these changes
Jun 6, 2019
earlephilhower
added a commit
to earlephilhower/Arduino
that referenced
this pull request
Jun 7, 2019
Undo the BearSSL RODATA->PROGMEM changes because there are some bad performance regressions in EC server operations which can result in timeouts and WDTs. Keep the shrunked bearssl.a library as that is orthogonal to the PROGMEM changes.
earlephilhower
added a commit
that referenced
this pull request
Jun 7, 2019
Undo the BearSSL RODATA->PROGMEM changes because there are some bad performance regressions in EC server operations which can result in timeouts and WDTs. Keep the shrunked bearssl.a library as that is orthogonal to the PROGMEM changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite all the integer math operations with const input parameters to
use PROGMEM properly (pgm_read_xx or memcpy_P), and move all the EC
order and generators and SHA OIDs to PROGMEM.
This frees around 1.2KB of heap for any SSL applications with no
perceptible speed impact.
Also delete unneeded objects from the bearssl.a library to shrink the
GIT repo size.
This runs everything I've tried without incident, but needs community testing to validate I've covered all the constant use cases