I2C slave support #5161
I2C slave support #5161
Conversation
Renaming, adding static keyword
Renaming, adding static keyword
|
@suculent sometimes these PRs just get lost in the noise since there are so few active maintainers, sorry! There are merge problems with the latest GIT and this patch. Would you be able to resolve them so we can take a look at it and see if we can put it in the next release? |
|
In addition to @earlephilhower 's comment, sometimes a PR is received, but there are no testers. We usually want feedback from at least one person other than the committer, preferably two others, about the state and usability. Sometimes that takes a long time, and then the PR needs updating due to other changes that happened in the meantime. |
|
Ok, thanks.
What’s the best way? Should the author pull master and create new PR?
I can do it as well, but it will require one more successful tester.
Odesláno z iPhonu
23. 9. 2018 v 22:46, Develo <notifications@github.com>:
… In addition to @earlephilhower 's comment, sometimes a PR is received, but there are no testers. We usually want feedback from at least one person other than the committer, preferably two others, about the state and usability. Sometimes that takes a long time, and then the PR needs updating due to other changes that happened in the meantime.
This PR can't be merges as-is, it needs resolving.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Sure, I’ll be happy to do it so I don’t have to hack my core on all my and frends’ workstations.
Give me 2 days.
Odesláno z iPhonu
23. 9. 2018 v 22:40, Earle F. Philhower, III <notifications@github.com>:
… @suculent sometimes these PRs just get lost in the noise since there are so few active maintainers, sorry!
There are merge problems with the latest GIT and this patch. Would you be able to resolve them so we can take a look at it and see if we can put it in the next release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@suculent whichever way is easiest is fine. If your pr pulls the original one, and just resolves conflicts, I think it would be enough confirmation. |
|
Fixed by #5162 |
Why is this not merged yet? It works for me pretty well...