Skip to content

Added default debug Mode to WifInfo boards #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2016
Merged

Conversation

hallard
Copy link
Contributor

@hallard hallard commented Jan 3, 2016

No description provided.

@Links2004
Copy link
Collaborator

if you set debug_port=Serial1 the sketch must include a Serial1.begin() or it may crash.
how do you ensure that every user will do this?
the DEBUG_ESP_WIFINFO define will not have any effect to the code what is the goal of it?

@hallard
Copy link
Contributor Author

hallard commented Jan 4, 2016

@Links2004
WifInfo sketch already include a Serial1.begin(), but good to know it's mandatory I will include it with #ifdef of the define.
the DEBUG_ESP_WIFINFO will be used in Wifinfo sktech like this user will be able to enable/disable debug from IDE, I will check this define in the sketch. But if there is a rule for define name or even not the good way to do this, I can change it, it's not fixed, just let me know.

Links2004 added a commit that referenced this pull request Jan 6, 2016
Added default debug Mode to WifInfo boards
@Links2004 Links2004 merged commit 0944e03 into esp8266:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants