Allow setting TCP timeout #1312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param timeout unsigned int | ||
| */ | ||
| void HTTPClient::setTimeout(uint16_t timeout) { | ||
| _tcpTimeout = timeout; |
There was a problem hiding this comment.
may add:
if(connected()) {
_tcp->setTimeout(timeout);
}to allow changing timeout when the connection is already there
There was a problem hiding this comment.
Great idea, thank you for that. I've added in your check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method to set TCP timeout for connect on HTTP requests. Not sure if its worth allowing this to be set at runtime though, but it was useful in one of my own projects.