Skip to content

incorrect bug fix. ESP8266 url encoded delimitters parsed incorrectly #3415

Closed
@Jeroen88

Description

@Jeroen88

Basic Infos

incorrect bug fix. ESP8266 url encoded delimitters parsed incorrectly

Hardware

Hardware: ESP-12E
Core Version: 2.4.0-rc1

Description

Problem description
URL encoded delimitter characters are decoded to early in the latest committed bug fix. A %-encoded '?', '=' and '&' are decoded to early. They should be decoded later.
So
line 94: searchString = urlDecode(url.substring(hasSearch + 1)); should be replaced (back) by searchString = url.substring(hasSearch + 1);
And
line 320: arg.key = data.substring(pos, equal_sign_index); should be replaced by arg.key = urlDecode(data.substring(pos, equal_sign_index));
line 321: arg.value = data.substring(equal_sign_index + 1, next_arg_index); should be replaced by arg.value = urlDecode(data.substring(equal_sign_index + 1, next_arg_index));

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions