Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix: scope for TSImportEqualsDeclaration #571

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 28, 2018

Import equal should declare "ImportBinding" variable in scope.

example:

import foo = require('bar')

https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require

this PR fixes ticket #555

@armano2 armano2 mentioned this pull request Nov 28, 2018
14 tasks
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mysticatea mysticatea added bug and removed triage labels Nov 29, 2018
@platinumazure platinumazure merged commit c5ffad3 into eslint:master Nov 30, 2018
@armano2 armano2 deleted the import-equal branch November 30, 2018 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants