This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Breaking: make 'useJSXTextNode:true' by default #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platinumazure
approved these changes
Nov 8, 2018
platinumazure
approved these changes
Nov 8, 2018
kaicataldo
approved these changes
Nov 8, 2018
JamesHenry
approved these changes
Nov 9, 2018
|
Looks like merging the other PR has caused some merge conflicts, but otherwise this looks ready to go. I'll do a major release once we land this. |
# Conflicts: # README.md # parser.js
|
@mysticatea Actually, should we wait for #540 to land before doing a release? |
|
@kaicataldo I have merged that PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the parser
useJSXTextNode: trueby default because the current ESLint assumes so.And add a note to README.md: "Please set
falseif you use this parser on ESLint v4."