This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Breaking: Support TypeScript 2.6 (fixes #394) #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be merged once TypeScript 2.6 is the stable version, as usual.
This branch is protected, any changes that go into master before this PR gets merged will need to be merged into the
ts-2.6branch - it cannot be rebased.This is our usual policy with these TypeScript upgrades, because it allows users to rely on commit hashes as installable versions.
Also, as usual, we are classifying this as a breaking change (to trigger our release tool to increment the major version number) if though there are no breaking code changes in the parser, as there is no downside to doing so and it better signals intentions to users.
Note: The build is currently failing on Node 4 as for some reason the corresponding version of NPM is saying that
~2.6.0-rcdoes not satisfy apeerDependencyrequirement of*🙄