This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Location data for typeAnnotations #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added some further detail on remaining differences in the comments in spec.js |
JamesHenry
force-pushed
the
type-annotation-loc
branch
2 times, most recently
from
f606683 to
cbf1258
Compare
JamesHenry
force-pushed
the
type-annotation-loc
branch
2 times, most recently
from
f02f1ec to
407341b
Compare
JamesHenry
force-pushed
the
type-annotation-loc
branch
from
407341b to
367d2a0
Compare
JamesHenry
force-pushed
the
type-annotation-loc
branch
3 times, most recently
from
cb2f3b0 to
d33ab10
Compare
JamesHenry
force-pushed
the
type-annotation-loc
branch
from
d33ab10 to
ead0d5a
Compare
|
Thanks for the pull request, @JamesHenry! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
soda0289
approved these changes
Sep 1, 2017
JamesHenry
force-pushed
the
type-annotation-loc
branch
from
ead0d5a to
92d7653
Compare
|
Thanks for the pull request, @JamesHenry! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These location data points are obviously not too important to any downstream tools right now, and the changes I have made appear to better align us with
babylonand the precendents set byflowI have also aligned better with
babylonas per discussion with Andy in another issue around the default value of many custom modifiers beingundefined.