This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Breaking: Explicitly handle TSEnumDeclaration (fixes #345) #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
JamesHenry
force-pushed
the
ts-enum-refactor
branch
from
482d2a1 to
634fc52
Compare
|
LGTM |
JamesHenry
commented
Aug 19, 2017
| @@ -19,7 +19,7 @@ | |||
| "license": "BSD-2-Clause", | |||
| "devDependencies": { | |||
| "babel-code-frame": "^6.22.0", | |||
| "babylon": "^7.0.0-beta.19", | |||
| "babylon": "^7.0.0-beta.20", | |||
There was a problem hiding this comment.
FYI 7.0.0-beta.20 contained an important fix for exported TS constructs so that is why I have set that as the new baseline
j-f1
approved these changes
Aug 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @j-f1, as per my comments on the other PR, for this solution I opted for explicitly handling the
TSEnumDeclaration, and I also wanted to make sure that we (typescript-eslint-parser and babylon) were aligned on the structure ofmembers, so I have also handledTSEnumMembers and verified this is the case.I don't believe the other elements from that PR were necessary to fix #345 in the end, so I left them out, but please let me know if you think I am missing something!